-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add imagePullSecrets on server test #572
Conversation
add image pull secrets
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to merge in the latest changes from master as well to get the imagePullSecrets
helper template.
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests pass when I merge in master locally, so I think this is good to go.
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com> Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
When deploying Vault on a private cluster and a private secured repository, server-test pull image fails cause of credentials
I propose to add imagePullSecrets on the pod