Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add imagePullSecrets on server test #572

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Conversation

shiinro
Copy link
Contributor

@shiinro shiinro commented Jul 19, 2021

When deploying Vault on a private cluster and a private secured repository, server-test pull image fails cause of credentials

I propose to add imagePullSecrets on the pod

add image pull secrets
@hashicorp-cla
Copy link

hashicorp-cla commented Jul 19, 2021

CLA assistant check
All committers have signed the CLA.

@tvoran tvoran self-requested a review July 23, 2021 00:18
@benashz benashz self-requested a review July 23, 2021 17:24
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to merge in the latest changes from master as well to get the imagePullSecrets helper template.

templates/tests/server-test.yaml Outdated Show resolved Hide resolved
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests pass when I merge in master locally, so I think this is good to go.

@tvoran tvoran merged commit c9c23b1 into hashicorp:master Aug 12, 2021
@tvoran tvoran mentioned this pull request Aug 19, 2021
illegalnumbers pushed a commit to streamnative/vault-helm that referenced this pull request Mar 17, 2022
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants