Add injector.webhookAnnotations chart option #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows setting annotations on the mutating webhook config
tomhjp
approved these changes
Aug 16, 2021
| {{- if .Values.injector.webhookAnnotations }} | ||
| annotations: | ||
| {{- $tp := typeOf .Values.injector.webhookAnnotations }} | ||
| {{- if eq $tp "string" }} |
There was a problem hiding this comment.
Is it worth supporting string for new options?
There was a problem hiding this comment.
Good question, though I feel like even with new options we need to keep supporting both types for consistency with the other annotation options in the chart.
illegalnumbers
pushed a commit
to streamnative/vault-helm
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting annotations on the mutating webhook config.
For example, if cert-manager is managing the certificates for vault-k8s, that would require setting the CA cert in the chart values (
injector.certs.caBundle). But, if thecert-manager.io/inject-ca-from: <namespace>/<secret>annotation is set on the mutating webhook config, cert-manager will keep the mutating webhook config updated with the CA from the Secret.