ingress stable networking api #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tvoran
reviewed
Aug 18, 2021
|
Thanks for this PR, it is required for K8S 1.22. I hope it will be merged soon :) |
tvoran
reviewed
Aug 25, 2021
There was a problem hiding this comment.
Would you also mind adding a test in test/unit/server-ingress.bats for the old Ingress style?
Something like:
helm template \
--show-only templates/server-ingress.yaml \
--set 'server.ingress.enabled=true' \
--kube-version 1.18.3 \
.
And then check for the apiVersion, serviceName, and servicePort.
|
@tvoran sorry for the delay, updated |
This was referenced Oct 9, 2021
|
@tvoran is there an ETA for this change to be released? Thanks! |
|
@np-13 Probably next week. |
illegalnumbers
pushed a commit
to streamnative/vault-helm
that referenced
this pull request
Mar 17, 2022
* Moved ingress to stable networking api * lower versions support * ingress disabled by default * added tests for old k8s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved ingress to stable api
#587