Feat: add externalTrafficPolicy support #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- externalTrafficPolicy can be set for both the ui and server services. It is only supported for NodePort or LoadBalancer service types.
benashz
commented
Oct 15, 2021
| {{- end }} | ||
| {{- end -}} | ||
|
|
||
| {{/* |
There was a problem hiding this comment.
This function is mostly unrelated to this fix, so I am okay if we forgo it. I see we have at least one other PR that introduces another LB so it might be good to keep it?
Idea: there is a ton of Service definition duplication in this chart. It is possible that we could move most of the duplication to shared functions.
tvoran
approved these changes
Oct 16, 2021
Thanks!
Currently they all share the same service values, so I think setting the policy as is should be ok. We can probably update it when/if the need arises. |
benashz
added a commit
that referenced
this pull request
Oct 21, 2021
benashz
added a commit
that referenced
this pull request
Oct 21, 2021
illegalnumbers
pushed a commit
to streamnative/vault-helm
that referenced
this pull request
Mar 17, 2022
- externalTrafficPolicy can be set for both the ui and server services. It is only supported for NodePort or LoadBalancer service types.
illegalnumbers
pushed a commit
to streamnative/vault-helm
that referenced
this pull request
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is only supported for NodePort or LoadBalancer service types.