Added support to configure default vault namespace on the agent config #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bradfordwagner
force-pushed
the
feature/webhook-default-namespace
branch
from
d13f951
to
f0f762e
Compare
tvoran
reviewed
Jul 19, 2022
There was a problem hiding this comment.
This looks like it's on the right track, though I'd like to also see tests in test/unit/injector-deployment.bats for the new option.
It also occurs to me that this PR may not strictly be necessary since the env var can already be set via the existing injector.extraEnvironmentVars option. For example:
# values.yaml
injector:
extraEnvironmentVars:
AGENT_INJECT_VAULT_NAMESPACE: "admin"
Or on the cli:
helm install vault hashicorp/vault \
--set injector.extraEnvironmentVars.AGENT_INJECT_VAULT_NAMESPACE="admin"
Comment on lines
+121
to
+122
| - name: AGENT_INJECT_VAULT_NAMESPACE | ||
| value: "{{ .Values.injector.agentDefaults.namespace }}" |
There was a problem hiding this comment.
I think this var should only be set if .Values.injector.agentDefaults.namespace isn't empty, similar to how AGENT_INJECT_TEMPLATE_STATIC_SECRET_RENDER_INTERVAL is handled above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to: hashicorp/vault-k8s#345