allow cpu/mem requests and limits to be set globally in the injector #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there documentation I should update as well? |
|
@joemiller I will update the documentation, thank you! |
There was a problem hiding this comment.
Hi @joemiller, thanks for the contribution! This looks great but can you add these environment variables to the deploy/deployment.yaml file?
|
Once that's added I'll approve this and merge @joemiller. Thanks again! |
joemiller
force-pushed
the
request-limits-global-config
branch
from
d61c1b2
to
87445be
Compare
|
@jasonodonnell updated the |
Adds new flags and env vars to the injector config that allow changing the cpu/mem requests and limits of the injected containers: - `-cpu-request` / `AGENT_INJECT_CPU_REQUEST` - `-cpu-limit` / `AGENT_INJECT_CPU_LIMIT` - `-mem-request` / `AGENT_INJECT_MEM_REQUEST` - `-mem-limit` / `AGENT_INJECT_MEM_LIMIT`
joemiller
force-pushed
the
request-limits-global-config
branch
from
87445be
to
5c045d6
Compare
RemcoBuddelmeijer
pushed a commit
to RemcoBuddelmeijer/vault-k8s
that referenced
this pull request
Feb 22, 2022
…ashicorp#235) Adds new flags and env vars to the injector config that allow changing the cpu/mem requests and limits of the injected containers: - `-cpu-request` / `AGENT_INJECT_CPU_REQUEST` - `-cpu-limit` / `AGENT_INJECT_CPU_LIMIT` - `-mem-request` / `AGENT_INJECT_MEM_REQUEST` - `-mem-limit` / `AGENT_INJECT_MEM_LIMIT`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new flags and env vars to the injector config that allow changing the cpu/mem
requests and limits of the injected containers:
-cpu-request/AGENT_INJECT_CPU_REQUEST-cpu-limit/AGENT_INJECT_CPU_LIMIT-mem-request/AGENT_INJECT_MEM_REQUEST-mem-limit/AGENT_INJECT_MEM_LIMITcloses #216
closes #166