Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: static_secret_render_interval #276

Merged
merged 5 commits into from
Aug 13, 2021
Merged

Feat: static_secret_render_interval #276

merged 5 commits into from
Aug 13, 2021

Conversation

burdandrei
Copy link
Contributor

Adds option to configure template config static_secret_render_interval

@burdandrei burdandrei force-pushed the feat-static-secret-render-interval branch from 9dcad69 to acbe8e2 Compare August 4, 2021 12:12
@burdandrei burdandrei force-pushed the feat-static-secret-render-interval branch from acbe8e2 to af73a1e Compare August 4, 2021 12:37
@burdandrei burdandrei mentioned this pull request Aug 4, 2021
Merged
@mrbrandao mrbrandao mentioned this pull request Aug 11, 2021
Open
tvoran
tvoran reviewed Aug 11, 2021
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions, mostly around the idea that we don't need to set a default for this config parameter, since vault agent has one already if the option is omitted from the config.

agent-inject/agent/annotations.go Outdated Show resolved Hide resolved
agent-inject/agent/config.go Outdated Show resolved Hide resolved
agent-inject/agent/agent.go Outdated Show resolved Hide resolved
agent-inject/agent/agent.go Outdated Show resolved Hide resolved
agent-inject/agent/agent.go Outdated Show resolved Hide resolved
agent-inject/agent/agent.go Outdated Show resolved Hide resolved
agent-inject/agent/annotations.go Outdated Show resolved Hide resolved
subcommand/injector/flags.go Outdated Show resolved Hide resolved
burdandrei and others added 2 commits August 12, 2021 13:02
@burdandrei @tvoran
Apply suggestions from code review
aa1a8ae 
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
@burdandrei
fix tests after suggestions
ce5a1a5
@burdandrei
Copy link
Contributor Author

Thanks for suggestions @tvoran!
Everything committed and tests passed.
Also, PRs include only CLA check right now.
Maybe we should add unit test run as a check as well?

tvoran
tvoran approved these changes Aug 13, 2021
View reviewed changes
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvoran
Copy link
Member

tvoran commented Aug 13, 2021

@burdandrei Yeah, the unit tests don't run on PRs from forks. We may want to revisit that in the future.

@tvoran tvoran merged commit 1025cca into hashicorp:master Aug 13, 2021
RemcoBuddelmeijer pushed a commit to RemcoBuddelmeijer/vault-k8s that referenced this pull request Feb 22, 2022
@burdandrei @tvoran
Feat: static_secret_render_interval (hashicorp#276)
51f0c74 
Co-authored-by: Theron Voran <tvoran@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvoran tvoran tvoran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burdandrei @tvoran