Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Oracle Instant Client to 19.18 #105

Merged
merged 4 commits into from
Feb 13, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ RUN yum update -y && yum install -y \
zip \
git

ENV GOLANG_VERSION 1.17.7
ENV GOLANG_VERSION 1.19.5

RUN set -eux; \
url="https://golang.org/dl/go${GOLANG_VERSION}.linux-amd64.tar.gz"; \
Expand All @@ -34,8 +34,8 @@ ENV PATH $GOPATH/bin:/usr/local/go/bin:$PATH
ENV PKG_CONFIG_PATH $GOPATH/src/github.com/hashicorp/vault-plugin-database-oracle/scripts/linux_amd64

RUN yum install -y \
oracle-instantclient19.6-basic \
oracle-instantclient19.6-devel
oracle-instantclient19.18-basic \
oracle-instantclient19.18-devel

RUN mkdir -p "$GOPATH/src" "$GOPATH/bin" "$GOPATH/src/github.com/hashicorp/vault-plugin-database-oracle" && chmod -R 777 "$GOPATH"

Expand All @@ -55,4 +55,4 @@ CMD echo "Please specify a command, e.g. 'make bin' or 'make test-ci'"
# Set default target to 'cross-image'.
#
# ===================================
FROM cross-image
FROM cross-image
24 changes: 21 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,29 @@ This project uses the database plugin interface introduced in Vault version 0.7.

This plugin is not compatible with Alpine Linux out of the box. Oracle's libraries are glibc dependant, and Alpine has musl as its default C library.

## Build
## Releases

For linux/amd64, pre-built binaries can be found at
[the releases page](https://releases.hashicorp.com/vault-plugin-database-oracle/).
See the following table to determine what version of the Oracle Instant Client
SDK the plugin was built with:

|Plugin Release|Instance Client Version|
|---|---|
|v0.8.0|19.18|
|v0.7.0|19.6 |
|v0.6.1|19.6 |
|v0.6.0|19.6 |
|v0.5.0|19.6 |
|v0.4.0|19.6 |
|v0.3.0|19.6 |
|v0.2.0|19.3 |

For linux/amd64, pre-built binaries can be found at [the releases page](https://releases.hashicorp.com/vault-plugin-database-oracle/) (built with Oracle Instant Client SDK 19.3)

For other platforms, there are not currently pre-built binaries available.
## Build

For platforms other than linux/amd64, there are not currently pre-built
binaries available.

Before building, you will need to download the Oracle Instant Client library, which is available from
[Oracle](http://www.oracle.com/technetwork/database/features/instant-client/index-097480.html). Download the SDK package to get the headers and
Expand Down
6 changes: 3 additions & 3 deletions scripts/linux_amd64/oci8.pc
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
libdir=/usr/lib/oracle/19.6/client64/lib
includedir=/usr/include/oracle/19.6/client64
libdir=/usr/lib/oracle/19.18/client64/lib
includedir=/usr/include/oracle/19.18/client64

Name: oci8
Description: oci8 library
Libs: -L${libdir} -lclntsh
Cflags: -I${includedir}
Version: 19.6
Version: 19.18