Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps #93

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Update deps #93

merged 2 commits into from
Nov 1, 2022

Conversation

fairclothjm
Copy link
Contributor

Steps:

go get github.com/hashicorp/vault/api@v1.8.2
go get github.com/hashicorp/vault/sdk@v0.6.1
go get github.com/ory/dockertest/v3
go mod tidy

@robmonte
Copy link
Member

Any reason why github.com/tgulacsi/go doesn't get updated to its newest patch version?

@fairclothjm
Copy link
Contributor Author

@robmonte Yes, newer releases have removed the package that we depend on. We are only using a single utility/string manipulation function in the unit test so I didn't think it was a problem.

austingebauer
austingebauer approved these changes Oct 31, 2022
View reviewed changes
Copy link

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fairclothjm fairclothjm merged commit 6f5f0e0 into main Nov 1, 2022
@fairclothjm fairclothjm deleted the update-deps branch November 1, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austingebauer austingebauer austingebauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fairclothjm @robmonte @austingebauer