-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add hierarchical path handling to static role endpoints #102
Conversation
753980f
to
cab0c82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR is looking good! Had a couple initial questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. I had a few minor suggestions, questions, and nits that you might want to address.
@benashz @vinay-gopalan I have addressed the bulk of your comments. Any remaining test improvements I will do once we get past feature freeze. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for all the clarifying comments, I am fine with additional test improvements being handled after feature freeze
This PR adds hierarchical path handling to the following APIs:
This allows creating a static role name with an arbitrary number of forward slashes. For example,
Where
org/platform/dev
is the role name. Creds can be read and rotated using the same role name and the respective API's. For example,Most importantly, this allows us to perform LIST operations to query the available roles. For example,