Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deps and prepare release v0.14.0 #113

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

thyton
Copy link
Contributor

@thyton thyton commented Sep 6, 2024

update deps, bump .go-version to 1.22.6 to match vault repo and prepare release v0.14.0

go list -u -m -json all | jq -r 'select(.Indirect != true and .Update != null) | .Path+"@"+.Update.Version' | xargs -L1 go get
go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp@latest
go get github.com/hashicorp/go-secure-stdlib/plugincontainer@latest
go get github.com/hashicorp/go-retryablehttp@latest
go mod tidy

@thyton thyton force-pushed the VAULT-27259/prepare-release-0.14.0 branch from d08d8e1 to 5b77ff3 Compare September 6, 2024 21:44
@thyton
Copy link
Contributor Author

thyton commented Sep 6, 2024

Tests passed locally. CI failure is similar to https://github.com/hashicorp/vault-plugin-database-couchbase/actions/runs/10708495222/job/29690926954

$ make test
==> Checking that code complies with gofumpt requirements...
CGO_ENABLED=0 go test ./...  -timeout=20m
?   	github.com/hashicorp/vault-plugin-secrets-openldap/client/tools	[no test files]
?   	github.com/hashicorp/vault-plugin-secrets-openldap/cmd/vault-plugin-secrets-openldap	[no test files]
?   	github.com/hashicorp/vault-plugin-secrets-openldap/ldapifc	[no test files]
ok  	github.com/hashicorp/vault-plugin-secrets-openldap	(cached)
ok  	github.com/hashicorp/vault-plugin-secrets-openldap/client	(cached)

@thyton thyton requested a review from a team September 6, 2024 22:33
@thyton thyton force-pushed the VAULT-27259/prepare-release-0.14.0 branch from 5b77ff3 to 33b24a7 Compare September 6, 2024 22:48
@tvoran
Copy link
Member

tvoran commented Sep 6, 2024

I feel like we shouldn't ignore the CI failure, since that will make it hard to release?

Suggest downgrading to a docker/docker version that's compatible with the current vault/sdk tag, something like:

go get github.com/ory/dockertest/v3@v3.10.0 \
  github.com/hashicorp/go-secure-stdlib/plugincontainer@v0.3.0 \
  github.com/docker/docker@v25.0.6 \
  github.com/docker/cli@v25.0.6
go mod tidy

@thyton
Copy link
Contributor Author

thyton commented Sep 7, 2024

Thank you, @tvoran!

@thyton thyton requested a review from tvoran September 7, 2024 01:22
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to update .go-version as well, and I noticed there's a dependabot PR that probably should go in too: #111

CHANGELOG.md Outdated Show resolved Hide resolved
@thyton thyton merged commit 3e42cbf into main Sep 9, 2024
4 checks passed
@thyton thyton deleted the VAULT-27259/prepare-release-0.14.0 branch September 9, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants