properly handle init queue for hierarchical paths #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
fairclothjm
deleted the
VAULT-30629/fix-init-queue/heirarchical-paths
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where roles names with hierarchical paths caused a panic on reloads of the backend.
Roles can be defined with hierarchical paths, e.g. "foo/bar/baz". Howerver, the storage.List() call to the top-level static role path will only return the top-level keys in the hierarchy. So we perform a non-recursive breadth-first search through all the keys returned from storage.List(). If a given node points to a static role, we append to the return slice and use that slice to initialize the queue.
Closes hashicorp/vault#27907
Closes #114