Use a digest to generate a memory key #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
justincampbell
force-pushed
the
use-digest-for-memory-key
branch
from
606b1fa
to
9a6e087
Compare
findkim
reviewed
May 21, 2019
justincampbell
force-pushed
the
use-digest-for-memory-key
branch
from
9a6e087
to
37806fb
Compare
findkim
approved these changes
May 21, 2019
There was a problem hiding this comment.
The changes look good! (pending another typo fix)
If i'm following the changes correctly, does this only effect how in-memory keys are digested and so no need to worry about backward compatibility issues here since any application would have to restart to fetch these changes?
The Ruby OpenSSL AES 128 cipher requires a 16-byte key. The previous implementation of #memory_key_for generated a base64 string and then truncated it to 16 bytes. This could cause longer paths/keys (and now contexts) to have the same memory key for different values. This change uses an MD5 digest to generate a mostly-unique key for different key/path/context inputs.
justincampbell
force-pushed
the
use-digest-for-memory-key
branch
from
37806fb
to
24b45e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ruby OpenSSL AES 128 cipher requires a 16-byte key. The previous implementation of #memory_key_for generated a base64 string and then truncated it to 16 bytes. This could cause longer paths/keys (and now contexts) to have the same memory key for different values.
This change uses an MD5 digest to generate a mostly-unique key for different key/path/context inputs.