Skip to content

Commit

Permalink
Have go-test timeout before the GH step timeout to gather information (
Browse files Browse the repository at this point in the history
…#28559)

- If we encounter a deadlock/long running test it is better to have go
   test timeout. As we've noticed if we hit the GitHub step timeout, we
   lose all information about what was running at the time of the timeout
   making things harder to diagnose.
 - Having the timeout through go test itself on a long running test it
   outputs what test was running along with a full panic output within
   the logs which is quite useful to diagnose
  • Loading branch information
stevendpclark authored Oct 2, 2024
1 parent 7efc1af commit 159e780
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion .github/workflows/test-go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ on:
required: false
default: 20
type: number
go-test-timeout:
description: The timeout parameter for Go tests
required: false
default: 50m
type: string
timeout-minutes:
description: The maximum number of minutes that this workflow should run
required: false
Expand Down Expand Up @@ -443,7 +448,7 @@ jobs:
-- \
$package_parallelism \
-tags "${{ inputs.go-tags }}" \
-timeout=${{ env.TIMEOUT_IN_MINUTES }}m \
-timeout=${{ inputs.go-test-timeout }} \
-parallel=${{ inputs.go-test-parallelism }} \
${{ inputs.extra-flags }} \
- name: Prepare datadog-ci
Expand Down

0 comments on commit 159e780

Please sign in to comment.