Skip to content

Commit

Permalink
command/server: add support to write pprof files to the filesystem vi…
Browse files Browse the repository at this point in the history
…a SIGUSR2 (#20609) (#20620)

* core/server: add support to write pprof files to the filesystem via SIGUSR2

* changelog

* Fix filepath join

* Use core logger

* Simplify logic

* Break on error

Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
  • Loading branch information
1 parent 3127e77 commit 15cde29
Show file tree
Hide file tree
Showing 2 changed files with 77 additions and 0 deletions.
4 changes: 4 additions & 0 deletions changelog/20609.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
```release-note:improvement
command/server: Add support for dumping pprof files to the filesystem via SIGUSR2 when
`VAULT_PPROF_WRITE_TO_FILE=true` is set on the server.
```
73 changes: 73 additions & 0 deletions command/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -1659,6 +1659,79 @@ func (c *ServerCommand) Run(args []string) int {
case <-c.SigUSR2Ch:
logWriter := c.logger.StandardWriter(&hclog.StandardLoggerOptions{})
pprof.Lookup("goroutine").WriteTo(logWriter, 2)

if os.Getenv("VAULT_STACKTRACE_WRITE_TO_FILE") != "" {
c.logger.Info("Writing stacktrace to file")

dir := ""
path := os.Getenv("VAULT_STACKTRACE_FILE_PATH")
if path != "" {
if _, err := os.Stat(path); err != nil {
c.logger.Error("Checking stacktrace path failed", "error", err)
continue
}
dir = path
} else {
dir, err = os.MkdirTemp("", "vault-stacktrace")
if err != nil {
c.logger.Error("Could not create temporary directory for stacktrace", "error", err)
continue
}
}

f, err := os.CreateTemp(dir, "stacktrace")
if err != nil {
c.logger.Error("Could not create stacktrace file", "error", err)
continue
}

if err := pprof.Lookup("goroutine").WriteTo(f, 2); err != nil {
f.Close()
c.logger.Error("Could not write stacktrace to file", "error", err)
continue
}

c.logger.Info(fmt.Sprintf("Wrote stacktrace to: %s", f.Name()))
f.Close()
}

// We can only get pprof outputs via the API but sometimes Vault can get
// into a state where it cannot process requests so we can get pprof outputs
// via SIGUSR2.
if os.Getenv("VAULT_PPROF_WRITE_TO_FILE") != "" {
dir := ""
path := os.Getenv("VAULT_PPROF_FILE_PATH")
if path != "" {
if _, err := os.Stat(path); err != nil {
c.logger.Error("Checking pprof path failed", "error", err)
continue
}
dir = path
} else {
dir, err = os.MkdirTemp("", "vault-pprof")
if err != nil {
c.logger.Error("Could not create temporary directory for pprof", "error", err)
continue
}
}

dumps := []string{"goroutine", "heap", "allocs", "threadcreate"}
for _, dump := range dumps {
pFile, err := os.Create(filepath.Join(dir, dump))
if err != nil {
c.logger.Error("error creating pprof file", "name", dump, "error", err)
break
}

err = pprof.Lookup(dump).WriteTo(pFile, 0)
if err != nil {
c.logger.Error("error generating pprof data", "name", dump, "error", err)
break
}
}

c.logger.Info(fmt.Sprintf("Wrote pprof files to: %s", dir))
}
}
}
// Notify systemd that the server is shutting down
Expand Down

0 comments on commit 15cde29

Please sign in to comment.