add a check to prevent panics (#5471)

hashicorp · Oct 5, 2018 · a353735 · a353735
1 parent 4888144
commit a353735
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/helper/ldaputil/client.go b/helper/ldaputil/client.go
@@ -377,6 +377,10 @@ func (c *Client) GetLdapGroups(cfg *ConfigEntry, conn Connection, userDN string,
 
 // EscapeLDAPValue is exported because a plugin uses it outside this package.
 func EscapeLDAPValue(input string) string {
+	if input == "" {
+		return ""
+	}
+
 	// RFC4514 forbids un-escaped:
 	// - leading space or hash
 	// - trailing space

diff --git a/helper/ldaputil/client_test.go b/helper/ldaputil/client_test.go
@@ -11,6 +11,7 @@ func TestLDAPEscape(t *testing.T) {
 		"test,hel+lo": "test\\,hel\\+lo",
 		"test\\hello": "test\\\\hello",
 		"  test  ":    "\\  test \\ ",
+		"":            "",
 	}
 
 	for test, answer := range testcases {