Skip to content

Commit

Permalink
Ensure tests-completed job fails if required jobs either fail or are …
Browse files Browse the repository at this point in the history
…cancelled (#19948)

Otherwise, the tests-completed job should succeed, including when the test-ui
job is skipped.
  • Loading branch information
kubawi authored Apr 3, 2023
1 parent e973716 commit de381c3
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -283,10 +283,8 @@ jobs:
- setup
- test-go
- test-ui
if: |
always() &&
!contains(needs.*.result, 'failure') &&
!contains(needs.*.result, 'cancelled')
if: always()
runs-on: ${{ fromJSON(needs.setup.outputs.compute-tiny) }}
steps:
- run: echo "All Go tests successfully passed"
- run: |
tr -d '\n' <<< '${{ toJSON(needs.*.result) }}' | grep -q -v -E '(failure|cancelled)'

0 comments on commit de381c3

Please sign in to comment.