review feedback

hashicorp · May 23, 2018 · f317154 · f317154
1 parent b050f5f
commit f317154
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 12 deletions.
diff --git a/ui/tests/acceptance/access/identity/_shared-alias-tests.js b/ui/tests/acceptance/access/identity/_shared-alias-tests.js
@@ -74,6 +74,4 @@ export const testAliasDeleteFromForm = (name, itemType, assert) => {
     assert.equal(aliasIndexPage.items.filterBy('id', aliasID).length, 0, `${itemType}: the row does not show in the list`);
     aliasIndexPage.flashMessage.latestMessage.startsWith('Successfully deleted', `${itemType}: shows flash message`);
   });
-
-
 };
diff --git a/ui/tests/unit/components/identity/edit-form-test.js b/ui/tests/unit/components/identity/edit-form-test.js
@@ -54,22 +54,20 @@ let testCases = [
     expected: 'vault.cluster.access.identity.aliases.show',
   },
 ];
-test('it computes cancelLink properly', function(assert) {
-  let component = this.subject();
-  let model;
-
-  testCases.forEach(testCase => {
-    model = Ember.Object.create({
-      identityType: testCase.identityType,
-      rollbackAttributes: sinon.spy(),
-    });
+testCases.forEach(function(testCase) {
+  let model = Ember.Object.create({
+    identityType: testCase.identityType,
+    rollbackAttributes: sinon.spy(),
+  });
+  test(`it computes cancelLink properly: ${testCase.identityType} ${testCase.mode}`, function(assert) {
+    let component = this.subject();
 
     component.set('mode', testCase.mode);
     component.set('model', model);
     assert.equal(
       component.get('cancelLink'),
       testCase.expected,
-      `${testCase.identityType} ${testCase.mode}: cancel link is correct`
+      'cancel link is correct'
     );
   });
 });