Make all duplicate removals stable in PKI #11259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HridoyRoy
approved these changes
Apr 1, 2021
sgmiller
added a commit
that referenced
this pull request
Apr 6, 2021
sgmiller
added a commit
that referenced
this pull request
Apr 6, 2021
sgmiller
added a commit
that referenced
this pull request
May 3, 2021
briankassouf
pushed a commit
that referenced
this pull request
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though x509 does not require an ordering of attribute-value pairs in a DN,
(order does not matter), our duplicate removal uses Go maps, which
explicitly don't have key ordering and often change between Go versions.
This creates confusion for users who expect what they set in a role to come
out verbatim in issued certs.