Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/k8s: updated helm doc for short-lived SA tokens #15675

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

tsaarni
Copy link
Contributor

@tsaarni tsaarni commented May 28, 2022

Helm docs still have example for Kubernetes Auth Method that store the SA token in configuration https://www.vaultproject.io/docs/platform/k8s/helm/examples/kubernetes-auth. Update the example to allow rotated tokens to be reloaded automatically.

xref #15390

Signed-off-by: Tero Saarni tero.saarni@est.tech

@tsaarni tsaarni requested a review from taoism4504 as a code owner May 28, 2022 10:19
@tsaarni
Copy link
Contributor Author

tsaarni commented May 28, 2022

This is only doc update so skipping the Changelog entry.

I think there is nothing specific to Helm in this doc, so not sure if the page is absolutely necessary, but since the page now exists it would be nice to have up to date info!

@heatherezell heatherezell added helmchart Helm chart for deploying Vault on Kubernetes. Also consider hashicorp/vault-helm k8s labels Aug 8, 2022
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, this looks like a great update, just one suggestion as I don't want us to encourage non-dev installers to use the root token.

Signed-off-by: Tero Saarni <tero.saarni@est.tech>
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs helmchart Helm chart for deploying Vault on Kubernetes. Also consider hashicorp/vault-helm k8s pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants