Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update namespace.FromContext comment #18840

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Update namespace.FromContext comment #18840

merged 1 commit into from
Feb 13, 2023

Conversation

swenson
Copy link
Contributor

@swenson swenson commented Jan 25, 2023

It looks like namespace context caching was removed in #5200
but this comment was left referencing it, which I found confusing at first glance.

Update namespace.FromContext comment
afab74b 
It looks like namespace context caching was removed in
#5200
but this comment was left referencing it, which I found confusing
at first glance.
@swenson swenson requested a review from a team February 13, 2023 18:48
@swenson
Copy link
Contributor Author

swenson commented Feb 13, 2023

Thanks!

@swenson swenson merged commit 063a782 into main Feb 13, 2023
@swenson swenson deleted the remove-ns-cache-comments branch February 13, 2023 19:04
This was referenced Feb 13, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncabatoff ncabatoff ncabatoff approved these changes

@briankassouf briankassouf Awaiting requested review from briankassouf

Assignees
No one assigned
Labels
pr/no-changelog pr/no-milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swenson @ncabatoff