Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAPI Go and C# #18896

Merged
merged 21 commits into from
Mar 23, 2023
Merged

Add OpenAPI Go and C# #18896

merged 21 commits into from
Mar 23, 2023

Conversation

yhyakuna
Copy link
Contributor

@yhyakuna yhyakuna commented Jan 30, 2023

Vault 1.13 Deliverable

🎫 Jira
🎟️ Asana

πŸ” Deploy preview

Update the Developer Quick Start page by adding new tabs in the Install Client Library, Authenticate to Vault, Store a secret & Retrieve a Secret for "OpenAPI Go (Beta)", and "OpenAPI C# (Beta)"

What's missing:

  • No example code in the vault-examples repo for OpenAPI Go and OpenAPI C#.

  • No code example equivalent to:

    if value != "Hashi123" {
        log.Fatalf("unexpected password value %q retrieved from vault", value)
    }
    

NOTE:
Had to switch <CodeTabs> to <Tabs> since the tab heading can NOT be customized using <CodeTabs>.

image

Co-authored-by: Anton Averchenkov <84287187+averche@users.noreply.github.com>
website/content/docs/get-started/developer-qs.mdx Outdated Show resolved Hide resolved
website/content/docs/get-started/developer-qs.mdx Outdated Show resolved Hide resolved
website/content/docs/get-started/developer-qs.mdx Outdated Show resolved Hide resolved
website/content/docs/get-started/developer-qs.mdx Outdated Show resolved Hide resolved
website/content/docs/get-started/developer-qs.mdx Outdated Show resolved Hide resolved
website/content/docs/get-started/developer-qs.mdx Outdated Show resolved Hide resolved
website/content/docs/get-started/developer-qs.mdx Outdated Show resolved Hide resolved
@averche
Copy link
Contributor

averche commented Mar 2, 2023

This is great! Thank you for adding these! πŸŽ‰

Could you please also add links to the following two under "The complete code samples for the steps below are available here:"

https://github.com/hashicorp/vault-client-go/#getting-started
https://github.com/hashicorp/vault-client-dotnet/#getting-started

yhyakuna and others added 7 commits March 3, 2023 10:11
Co-authored-by: Anton Averchenkov <84287187+averche@users.noreply.github.com>
Co-authored-by: Anton Averchenkov <84287187+averche@users.noreply.github.com>
Co-authored-by: Anton Averchenkov <84287187+averche@users.noreply.github.com>
Co-authored-by: Anton Averchenkov <84287187+averche@users.noreply.github.com>
Co-authored-by: Anton Averchenkov <84287187+averche@users.noreply.github.com>
Co-authored-by: Anton Averchenkov <84287187+averche@users.noreply.github.com>
Co-authored-by: Anton Averchenkov <84287187+averche@users.noreply.github.com>
@yhyakuna yhyakuna marked this pull request as ready for review March 3, 2023 18:12
@yhyakuna yhyakuna removed this from the 1.13.0 milestone Mar 3, 2023
Co-authored-by: AnPucel <adiroff@hashicorp.com>
yhyakuna and others added 2 commits March 3, 2023 18:39
Co-authored-by: Anton Averchenkov <84287187+averche@users.noreply.github.com>
yhyakuna and others added 4 commits March 8, 2023 20:19
Co-authored-by: AnPucel <adiroff@hashicorp.com>
Co-authored-by: AnPucel <adiroff@hashicorp.com>
Co-authored-by: AnPucel <adiroff@hashicorp.com>
Co-authored-by: AnPucel <adiroff@hashicorp.com>
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you πŸŽ‰

Copy link
Contributor

@AnPucel AnPucel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants