Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trap errors related to vault pki list-intermediate issuer reading #19165

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Trap errors related to vault pki list-intermediate issuer reading #19165

merged 4 commits into from
Feb 14, 2023

Commits on Feb 13, 2023

  1. Rename files to match test suite and existing pattern

    @stevendpclark
    stevendpclark committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    4d4f663 View commit details
    Browse the repository at this point in the history

  2. Factor out issuer loading into a dedicated function 

     - Add a little more checks/validation when loading the a PKI issuer
 - Factor out the issuer loading into a dedicated function
 - Leverage existing health check code to parse issuer certificates
    @stevendpclark
    stevendpclark committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    5599e5c View commit details
    Browse the repository at this point in the history

  3. Read parent issuer once instead of reloading it for every child 

     - Read in our parent issuer once instead of running it for every child
   we want to compare against
 - Provides clearer error message that we have failed reading from which
   path to the end user
    @stevendpclark
    stevendpclark committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    19f2390 View commit details
    Browse the repository at this point in the history

  4. PR Feedback 

     - Rename a variable for clarity
 - Use readIssuer in the validation of the parent issuer within
   pkiIssuer
 - Add some missing return 1 statements in error handlers that had been
   missed
    @stevendpclark
    stevendpclark committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    7e7c1b9 View commit details
    Browse the repository at this point in the history