Kubernetes config payload fix #19184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zofskeez
commented
Feb 14, 2023
| @@ -32,7 +32,7 @@ export default class KubernetesRoleAdapter extends NamedPathAdapter { | |||
| } | |||
| generateCredentials(backend, data) { | |||
| const generateCredentialsUrl = `${this.buildURL()}/${encodePath(backend)}/creds/${data.role}`; | |||
|
|
|||
| delete data.role; | |||
There was a problem hiding this comment.
Noticed that this was causing a warning to display since role is not an accepted value in the post body.
There was a problem hiding this comment.
Could this also be added to the serializer as serialize: false ?
There was a problem hiding this comment.
Since this is a custom adapter method the serializer is not hit. We decided not to have a dedicated model for role credentials since they are not persisted in the app which is why we are using the role adapter for the request. The payload is also not the role model but a pojo of values from the form.
There was a problem hiding this comment.
Oh right! I missed the method - thanks for explaining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After entering in values in the manual configuration form for a Kuberenetes secrets engine and either changing to the local cluster option or saving and then editing and changing to local cluster, the previously entered values would be sent to the server and saved. This was causing issues so the solution was to unset them in the serializer.