Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events: WS protobuf messages should be binary #19232

Merged
merged 6 commits into from
Feb 17, 2023
Merged

events: WS protobuf messages should be binary #19232

merged 6 commits into from
Feb 17, 2023

Commits on Feb 16, 2023

  1. events: WS protobuf messages should be binary 

    The [WebSockets spec](https://www.rfc-editor.org/rfc/rfc6455) states
that text messages must be valid UTF-8 encoded strings, which protobuf
messages virtually never are.

This instead correctly sends the protobuf events as binary messages.
    Christopher Swenson committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    03ce45d View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. bump eventlogger to fix race condition

    Christopher Swenson committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    f76bf8b View commit details
    Browse the repository at this point in the history

  2. Use cloudevents JSON format for websockets

    Christopher Swenson committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8900f3d View commit details
    Browse the repository at this point in the history

  3. Remove timestamp, extra newline from events JSON

    Christopher Swenson committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    b988497 View commit details
    Browse the repository at this point in the history

  4. Log only payload to avoid weird race condition in formatted

    Christopher Swenson committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    25e52df View commit details
    Browse the repository at this point in the history

  5. Use Format method to get read lock

    Christopher Swenson committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    2105c68 View commit details
    Browse the repository at this point in the history