Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OIDC provider docs for IBM ISAM #19247

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 17, 2023

This adds the docs for the IBM ISAM OIDC provider

@ghost ghost requested a review from yhyakuna as a code owner February 17, 2023 14:07
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 17, 2023

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@austingebauer
Copy link
Contributor

Thanks for this, @godvoigt! Are you able to sign the CLA?

@austingebauer
Copy link
Contributor

This is looking good, but I think it's missing a few things. Could you add changes similar to what was done in https://github.com/hashicorp/vault/pull/16274/files?

@ghost
Copy link
Author

ghost commented Feb 24, 2023

Hi @austingebauer, I will take a look at your suggestion.

As for the CLA, it's the same as for hashicorp/vault-plugin-auth-jwt#222. I signed it, but the state is not updated here. Clicking on "Refresh it" only takes me to my Github profile.

@ghost
Copy link
Author

ghost commented Feb 27, 2023

@austingebauer I've added the files you requested similar to the SecureAuth implementation. I also fixed the CLA now (my company mail changed a while ago and I hadn't configured / verified the new one in GitHub)

Copy link
Contributor

@austingebauer austingebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @godvoigt!

@austingebauer austingebauer added this to the 1.14 milestone Apr 6, 2023
@austingebauer austingebauer merged commit c94e213 into hashicorp:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants