Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for event format #19264

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Test coverage for event format #19264

merged 1 commit into from
Feb 21, 2023

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Feb 20, 2023

I messed up merging in main from #19246, so this re-adds the test coverage I had meant to include on event formatting, plus extends it a little bit now that it's asserting about cloud events formatted events rather than just the payload.

@tomhjp tomhjp added this to the 1.13.0 milestone Feb 20, 2023
@tomhjp tomhjp requested a review from swenson February 20, 2023 19:15
Copy link
Contributor

@swenson swenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomhjp tomhjp merged commit 88dcb04 into main Feb 21, 2023
@tomhjp tomhjp deleted the events-format-test branch February 21, 2023 17:18
@tomhjp
Copy link
Contributor Author

tomhjp commented Feb 21, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants