Backport of Restore 'server' and 'agent' base loggers to use their original names into release/1.13.x #19308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/fix/pr-18031/base-logger-names/tightly-on-iguana
branch
2 times, most recently
from
6855609
to
d59d84c
Compare
peteski22
approved these changes
Feb 23, 2023
…names/tightly-on-iguana
peteski22
deleted the
backport/fix/pr-18031/base-logger-names/tightly-on-iguana
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19304 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
When we added additional logging features to
serverandagentin #18031, we introduced an unintended change to the base logger names in both commands (setting them tovaultandvault-agentrespectively).This PR restores the original names (in the case of
serverhas no name) so that any log ingestion/parsing by downstream systems would not be impacted. Furthermore it also means that endpoints such assys/loggersfunction as expected and don't require avault.prefix forserverloggers.Overview of commits