Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-13763 normalize activity log mount paths #19343

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

miagilepner
Copy link
Contributor

Mount paths "auth/foo/" and "auth/foo" should both be represented as "auth/foo/" by the activity log responses, with the clients in those paths getting correctly deduplicated.

I didn't create a changelog entry since there's already one for the original change: #18916

Copy link
Contributor

@mpalmi mpalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about the comment on line 269 - this is no longer true since the mount accessor doesn't replace the path anymore, right? Just want to confirm my understanding! 😁

@miagilepner
Copy link
Contributor Author

I'm curious about the comment on line 269 - this is no longer true since the mount accessor doesn't replace the path anymore, right? Just want to confirm my understanding! 😁

The comment on mountAccessorToMountPath is still true - the mount accessor still gets transformed to a mount path, and that's returned. But that mount path will always have a / on the end of it, so we won't have that issue where we end up with both auth/token and auth/token/ in the mounts array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants