Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of add nil check for secret id entry on delete via accessor into release/1.10.x #19348

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19186 to be assessed for backporting due to the inclusion of the label backport/1.10.x.

The below text is copied from the body of the original PR.


This PR adds a nil check for the secret ID entry when deleting via secret id accessor. This fixes a scenario where a secret_id can be deleted by providing a valid accessor to the destroy endpoint on any role in the same mount.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/davidadeleon/add-secretid-accessor-nil-check/evidently-internal-guinea branch from aee688e to b198a44 Compare February 24, 2023 18:18
…-accessor-nil-check/evidently-internal-guinea
@mladlow mladlow merged commit d351364 into release/1.10.x Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants