Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Identity manager secure context fallback into release/1.13.x #19407

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19403 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

The below text is copied from the body of the original PR.


This PR removes crypto and adds the uuid package since crypto is only available in secure contexts.

crytpo.randomUUID() was used to set an id for dr and performance replication attribute records returned on the cluster since there is no unique key for Ember Data to store the record. It was also used for the nonce value when logging in with the okta auth method when a number challenge is required.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/identity-manager-secure-context-check/noticeably-adapted-reindeer branch from 20e201b to 77873c3 Compare February 28, 2023 19:26
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/identity-manager-secure-context-check/noticeably-adapted-reindeer branch from 688c0bf to 2c9bbcc Compare February 28, 2023 19:26
@zofskeez zofskeez enabled auto-merge (squash) February 28, 2023 19:30
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hellobontempo hellobontempo added ui bug Used to indicate a potential bug labels Feb 28, 2023
@hellobontempo hellobontempo added this to the 1.13.0 milestone Feb 28, 2023
@zofskeez zofskeez merged commit 75f1ea2 into release/1.13.x Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants