Backport of Pass encodeBase64 param to transit-key-actions into release/1.13.x #19465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/VAULT-14109/HMAC-BASE64-BUG/willingly-valid-dog
branch
2 times, most recently
from
85fbf6a
to
c07f7b6
Compare
Monkeychip
approved these changes
Mar 6, 2023
…4-BUG/willingly-valid-dog
…4-BUG/willingly-valid-dog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19429 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
A fix for the GH Issue here.
We missed passing the
encodeBase64param to thedoSubmitaction onhmac.hbs. You can see from other transit-key-action forms that show this option they pass this param in the hash to this action.Added test coverage with minimal changes so the fix can be backported.
The checkbox under codemirror was the checkbox in question.
Overview of commits