VAULT-14048: raft-autopilot appears to refuse to remove a node which has left and wouldn't impact stability #19472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteski22
added
bug
ncabatoff
reviewed
Mar 14, 2023
peteski22
assigned hc-github-team-secure-vault-core and unassigned hc-github-team-secure-vault-core
miagilepner
reviewed
Mar 27, 2023
miagilepner
reviewed
Mar 27, 2023
Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com>
raskchanky
reviewed
Mar 27, 2023
ncabatoff
reviewed
Apr 3, 2023
added 7 commits
April 3, 2023 16:01
ncabatoff
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was detected during manual testing for the
1.13.0release and as a precaution the following PRs were reverted:After some investigation the problem seems to be that the
NodeTypeisn't being supplied by Vault when autopilot asks it for itsKnownServersduring pruning. As a result there are no potential voters flagged in the voter registry, we have amaxRemovalwhich is< 1which triggers the debug message about removing a majority of voting servers being unsafe and autopilot refuses to remove the failed voting server.This PR adds the
NodeTypefor the leader and, where possible, for the follower nodes. It also restores the autopilot version tov0.2.0.Files of note:
go.modphysical/raft/raft_autopilot.govault/external_tests/raft/raft_autopilot_test.goMost other changed files are due to exportingGetRaftBackend.Tests added:
TestDelegate_KnownServers_NodeTypeTestRaft_Autopilot_DeadServerCleanupFollowing a successfully merged PR I will raise an Enterprise specific PR to update the packages and add another test.