Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Glimmerize - Colocate template and remove component file #19569

Merged
merged 9 commits into from
Mar 17, 2023
Merged

UI: Glimmerize - Colocate template and remove component file #19569

merged 9 commits into from
Mar 17, 2023

Conversation

kiannaquach
Copy link
Contributor

@kiannaquach kiannaquach commented Mar 15, 2023 •
edited
Loading

  • VAULT-14184: Move FormError template so it is co-located and remove the component file since the component file was just there to reference the layout location.
  • VAULT-14232 Move LayoutLoading template so it's co-located and remove the component file
  • VAULT-14233 Move MenuLoader template so it's co-located and remove component file
  • VAULT-14278 Move VaultLogoSpinner template so it's co-located and remove component file
  • VAULT-14276 Move Toolbar template so it's co-located and remove component file
  • VAULT-14275 Move ToolbarAction template so it's co-located and remove component file
  • VAULT-14283 Move ToolbarFilters template so it's co-located and remove component file
  • VAULT-14270 Move SearchSelectPlaceholder template so it's co-located and remove component file
  • VAULT-14268 Move PopupMenu template so it's co-located and remove component file

@kiannaquach kiannaquach added this to the 1.14 milestone Mar 15, 2023
@kiannaquach kiannaquach changed the title VAULT-14184 Move FormError template and remove component file UI: Glimmerize - Colocate template and remove component file Mar 15, 2023
@kiannaquach kiannaquach changed the base branch from main to ui/glimmerize-core-components March 15, 2023 22:05
@kiannaquach kiannaquach marked this pull request as ready for review March 15, 2023 22:07
@kiannaquach kiannaquach mentioned this pull request Mar 16, 2023
Closed
hashishaw
hashishaw approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@kiannaquach kiannaquach changed the base branch from ui/glimmerize-core-components to main March 16, 2023 16:50
@kiannaquach kiannaquach merged commit 40c4684 into main Mar 17, 2023
@kiannaquach kiannaquach deleted the ui/glimmerize-component-colocate branch March 17, 2023 14:38
raymonstah pushed a commit that referenced this pull request Mar 17, 2023
@kiannaquach @raymonstah
UI: Glimmerize - Colocate template and remove component file (#19569)
76c7871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashishaw hashishaw hashishaw approved these changes

Assignees
No one assigned
Labels
pr/no-changelog ui
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
2 participants
@kiannaquach @hashishaw