Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of Fix remount for mounts with spaces in the name into release/1.13.x #19590

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Backport of Fix remount for mounts with spaces in the name into release/1.13.x #19590

merged 1 commit into from
Mar 16, 2023

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19585 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

The below text is copied from the body of the original PR.

Context:

  • We made a change to avoid trailing spaces in mount names for remount here (as mounts cannot have trailing spaces): Fixes from mount move testing #14492
  • We instead made the change to any and all spaces in mount names
  • Mount names can have spaces in them, so this was a breaking change, and there was no reason for us to remove this behaviour

Fixes #18236

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/violethynes/fix-vault-secrets-move-whitespace/preferably-bursting-eagle branch from b7b5296 to e794035 Compare March 16, 2023 19:27
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/violethynes/fix-vault-secrets-move-whitespace/preferably-bursting-eagle branch from 67070c2 to 4ffe1aa Compare March 16, 2023 19:27
@VioletHynes VioletHynes enabled auto-merge (squash) March 16, 2023 19:27
@VioletHynes VioletHynes merged commit 99e4d5c into release/1.13.x Mar 16, 2023
@VioletHynes VioletHynes deleted the backport/violethynes/fix-vault-secrets-move-whitespace/preferably-bursting-eagle branch March 16, 2023 19:54
@fopina-ci fopina-ci mentioned this pull request Apr 27, 2023
Closed
@fopina-ci fopina-ci mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VioletHynes VioletHynes VioletHynes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hc-github-team-secure-vault-core @VioletHynes