Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Implementing the plugin version interface #19606

Merged
merged 4 commits into from
Mar 20, 2023
Merged

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Mar 17, 2023

I forgot to add this around the release of 1.12, but this explains how external plugin developers can opt in to the plugin version interface, and what implications that has.

Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we also want to add this version information to https://developer.hashicorp.com/vault/docs/secrets/databases/custom which is specifically about Database plugin development?

@tomhjp
Copy link
Contributor Author

tomhjp commented Mar 20, 2023

Wondering if we also want to add this version information to https://developer.hashicorp.com/vault/docs/secrets/databases/custom which is specifically about Database plugin development?

Thanks, good point. I've made a partial with some shared content, and then a little bit of text after that's more focussed on each context.

Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one question that might be good to add as clarification to the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants