Backport of Suppress event broker not started log warning into release/1.13.x #19620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/fix-event-broker-not-started-warning/nominally-hot-yeti
branch
from
4285eb5
to
c86ff0e
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/fix-event-broker-not-started-warning/nominally-hot-yeti
branch
from
c059026
to
c4d5d01
Compare
tomhjp
approved these changes
Mar 20, 2023
tomhjp
deleted the
backport/fix-event-broker-not-started-warning/nominally-hot-yeti
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19593 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
Fixes #19502
The other way I considered fixing this was using
errors.Isand returning a success response if it's the sentinel error. That required moving the sentinel error definition to the sdk, but otherwise felt like much of a muchness. Let me know if you think we can do it more elegantly though.Overview of commits