Add ACME new account creation handlers #19820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
force-pushed
the
cipherboy-add-new-account-creation
branch
from
a50e9eb
to
374b00f
Compare
cipherboy
commented
Mar 29, 2023
stevendpclark
approved these changes
Mar 29, 2023
cipherboy
force-pushed
the
cipherboy-add-new-account-creation
branch
from
374b00f
to
7d84d55
Compare
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
This handler supports two pieces of functionality: 1. Searching for whether an existing account already exists. 2. Creating a new account. One side effect of our JWS parsing logic is that we needed a way to differentiate between whether a JWK existed on disk from an account or if it was specified in the request. This technically means we're potentially responding to certain requests with positive results (e.g., key search based on kid) versus erring earlier like other implementations do. No account storage has been done as part of this commit. Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
cipherboy
force-pushed
the
cipherboy-add-new-account-creation
branch
from
7d84d55
to
49a7cb3
Compare
stevendpclark
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #19803; will be rebased once that is complete.We start adding handlers for ACME accounts, and in particular, the New Account mechanism.
One thing that isn't clear is whether the account path (from the KID) is meant to be fetched directly or not. We'll also need to handle converting the kid into a sanitized/kid-only version (without the URL) to fetch from disk.
This does make it clear though that, barring a single static RR URL for all nodes in a cluster, ACME would require the account KID to point to a specific PR cluster.