-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download Application log files and upload as an artifact when enos scenarios fail #19860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to add this to the enos-release-testing
workflows
uses: actions/upload-artifact@v3 | ||
with: | ||
# The name of the artifact is the same as the matrix scenario name with the spaces replaced with underscores. | ||
name: ${${{ matrix.scenario }}// /_}.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't zip this directory, so don't need the .zip
extension in the name
with: | ||
# The name of the artifact is the same as the matrix scenario name with the spaces replaced with underscores. | ||
name: ${${{ matrix.scenario }}// /_}.zip | ||
path: $ENOS_DEBUG_DATA_ROOT_DIR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be relative to repo root, so we will need to add ./enos/$ENOS_DEBUG_DATA_ROOT_DIR
. Not sure it accepts relative paths. Also reading the upload action looks like we need to pass the dir as $GITHUB_ENV variable. May be we can create a dir in /tmp
and set it as $GITHUB_ENV variable, and pass that to both ENOS_DEBUG_DATA_ROOT_DIR
and path ?
f4cb40c
to
4e27760
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 🚢 🚀
Recently the enos-provider was updated to add automatic application log file collection for all vault and remote exec resources. This PR updates the enos run workflow to turn on this feature and to add an upload artifact step to store the logs in the build artifacts. The logs will be zipped up in a file that has the same name as the scenario that failed, with spaces being replaced by underscores.