VAULT-14733: Refactor processClientRecord in activity log #19933
Conversation
|
Do we need to backport to 1.9 or 1.10? |
| } | ||
| } | ||
|
|
||
| func (p *processCounts) contains(client *activity.EntityRecord) bool { |
There was a problem hiding this comment.
Where is this used? I couldn't find a reference to it.
There was a problem hiding this comment.
It's actually not used here - it's used in testing in a later change that's on top of this one. However, since it relates to the code here, I included it. Let me know if you would prefer that I remove it and add it to a later PR
There was a problem hiding this comment.
Ah, cool! Thanks for the context!
I labeled it as a backport to older versions so that this code will be available when we need to test upgrade scenarios for client counts. However, it may make more sense to get the implementation working in supported versions, then backport later. I'll remove the labels here and make a separate ticket in the epic for earlier version backports. |
This makes it easier to split up the precomputed query worker and unit test its components.