VAULT-14733: SegmentReader interface for reading activity log segments #19934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raskchanky
reviewed
Apr 3, 2023
hghaf099
reviewed
Apr 4, 2023
hghaf099
reviewed
Apr 5, 2023
|
|
||
| // writeSegment writes a single segment file with the given time and index | ||
| // the correct path is inferred from the datatype of `item` | ||
| func writeSegment(t *testing.T, core *Core, ts time.Time, index int, item proto.Message) { |
There was a problem hiding this comment.
Would you think instead of having a generic function in which we would need to add logic to distinguish which item type we are dealing with, having two functions writeTokenSegment and writeEntitySegment would be more readable? This way, we could also remove the makeSegmentPath function as well, as that could be reduced to just a fmt.Sprintf call.
hghaf099
reviewed
Apr 5, 2023
This was referenced Apr 6, 2023
miagilepner
added a commit
that referenced
this pull request
Apr 6, 2023
#19934) * create a segment reader for activity log segment * fix imports * updates based on comments
miagilepner
added a commit
that referenced
this pull request
Apr 6, 2023
#19934) * create a segment reader for activity log segment * fix imports * updates based on comments
miagilepner
added a commit
that referenced
this pull request
Apr 11, 2023
… log segments into release/1.11.x (#20016) * VAULT-14733: SegmentReader interface for reading activity log segments (#19934) * create a segment reader for activity log segment * fix imports * updates based on comments * format * add missing import --------- Co-authored-by: miagilepner <mia.epner@hashicorp.com>
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a SegmentReader interface and an implementation to read segment files from storage for use in the activity log.
This makes it easier to allow new inputs (such as mock data) to the precomputed query worker.