Node Version CI Update #19978
Node Version CI Update #19978
Conversation
| - name: Set up node and yarn | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16 | ||
| node-version: ${{ steps.node-version.outputs.version}} |
There was a problem hiding this comment.
Hey, I think we can slightly streamline this workflow by using the Node version file option.
The suggestion below means that we wouldn't need the Read node version from .nvmrc step. We use something similar when setting up Go and had no issues so far, you can see an example here.
| node-version: ${{ steps.node-version.outputs.version}} | |
| node-version-file: './ui/.nvmrc' |
There was a problem hiding this comment.
@kubawi that is definitely a more streamlined option and since that option supports using package.json that's even better. Thanks for the suggestion! The test-enos-scenario-ui.yml workflow was doing something similar for both the go and node versions so I updated it there as well if you wouldn't mind having a look.
There was a problem hiding this comment.
Yep, looks good. I left an approval on the PR 👍
To simplify updating the node version used to build the UI, this PR updates the
ciandbuild-vault-ossgithub workflows to read the node version from theui/.nvmrcfile.