Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Add mechanism to disable automatic rollbacks into release/1.13.x #20040

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #19748 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

The below text is copied from the body of the original PR.


When testing the rollback mechanism, there's two categories of tests typically written:

  1. Ones in which the rollback manager is entirely left alone, which usually are a bit slower and less predictable. However, it is still sufficient in many scenarios.
  2. Ones in which the rollback manager is explicitly probed by tests and "stepped" to achieve the next rollback.

Here, without a mechanism to fully disable the rollback manager's periodic ticker (without affecting its ability to work!) we'll continue to see races of the sort:

--- FAIL: TestRevocationQueue (50.95s)
panic: sync: WaitGroup is reused before previous Wait has returned [recovered]
    panic: sync: WaitGroup is reused before previous Wait has returned

This allows us to disable the ticker, returning control to the test suite entirely.


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/cipherboy-add-better-rollback-manager-test-hooks/equally-sunny-owl branch from 38affc2 to ee0d996 Compare April 7, 2023 12:21
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/cipherboy-add-better-rollback-manager-test-hooks/equally-sunny-owl branch from 27ac3b5 to ec2f3fc Compare April 7, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants