add max_entry_size to sanitized config output #20044
Conversation
| defer ln.Close() | ||
| TestServerAuth(t, addr, token) | ||
| for _, tc := range cases { | ||
| tc := tc |
There was a problem hiding this comment.
nit: should this be removed?
There was a problem hiding this comment.
I believe this is a common pattern to capture the loop variable inside a closure (see: #16872 for an example).
There was a problem hiding this comment.
Thanks for calling that out. I meant to add t.Parallel to these which is why the capturing is present. I'll add parallelism.
| defer ln.Close() | ||
| TestServerAuth(t, addr, token) | ||
| for _, tc := range cases { | ||
| tc := tc |
There was a problem hiding this comment.
I believe this is a common pattern to capture the loop variable inside a closure (see: #16872 for an example).
http/sys_config_state_test.go
Outdated
| expectedHAStorageOutput map[string]interface{} | ||
| }{ | ||
| { | ||
| "raft storage", |
There was a problem hiding this comment.
nit: these test cases would be a bit more readable if we used named struct fields, e.g.
{
name: "raft storage",
storageConfig: &server.Storage{...},
...
}There was a problem hiding this comment.
Good point, I'll change that. GoLand has a UI treatment to identify which fields are which but that doesn't help those using a different IDE, or reading it in GitHub. Thanks for the feedback!
* add max_entry_size to sanitized config output * add changelog entry * add test parallelism * add inmem test case * use named struct fields for TestSysConfigState_Sanitized cases
* add max_entry_size to sanitized config output * add changelog entry * add test parallelism * add inmem test case * use named struct fields for TestSysConfigState_Sanitized cases
This PR adds a
raftsub-field to the sanitized config storage and HA storage details in order to expose Raft's max_entry_size.