Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: fix browser console formatting into release/1.13.x #20088

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #20064 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

The below text is copied from the body of the original PR.


During the Ember upgrade to 3.24 we implemented some linting changes that inadvertently affected the browser console’s output. Each command should be on a separate line. Fixes #19568

before

Screenshot 2023-04-10 at 10 16 02 AM

after fix

  • each command is on a separate line
  • previous command displays beside chevron icon > (not on line below)

Screenshot 2023-04-10 at 10 22 58 AM


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-15381/ui-browser-console-formatting/usefully-proud-coral branch from f980e0b to 13d0337 Compare April 11, 2023 17:43
@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/ui/VAULT-15381/ui-browser-console-formatting/usefully-proud-coral branch from 8bc5495 to b6f449b Compare April 11, 2023 17:43
@hellobontempo hellobontempo added ui backport bug Used to indicate a potential bug labels Apr 11, 2023
@hellobontempo hellobontempo added this to the 1.13.2 milestone Apr 11, 2023
* fix template-lintrc file

* add prettier ignore
@hellobontempo
Copy link
Contributor

Also includes changes from #20094

Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hellobontempo hellobontempo merged commit ac3b4e4 into release/1.13.x Apr 12, 2023
@hellobontempo hellobontempo deleted the backport/ui/VAULT-15381/ui-browser-console-formatting/usefully-proud-coral branch April 12, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants