Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.11: sdk/ldaputil: add connection_timeout configurable (#20144) #20159

Merged
merged 3 commits into from
Apr 17, 2023

Conversation

jasonodonnell
Copy link
Contributor

Backport failed so I did this manually.

* sdk/ldaputil: add connection_timeout configurable

* changelog

* Update doc

* Fix test

* Change default to 30s
@jasonodonnell jasonodonnell added this to the 1.11.10 milestone Apr 13, 2023
@jasonodonnell jasonodonnell requested a review from a team April 13, 2023 19:53
@jasonodonnell jasonodonnell enabled auto-merge (squash) April 13, 2023 19:53
@jasonodonnell jasonodonnell changed the title sdk/ldaputil: add connection_timeout configurable (#20144) Backport 1.11: sdk/ldaputil: add connection_timeout configurable (#20144) Apr 13, 2023
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonodonnell
Copy link
Contributor Author

Merging this for the changelog but #20200 will fix the race condition.

@jasonodonnell jasonodonnell merged commit fc83ff2 into release/1.11.x Apr 17, 2023
@jasonodonnell jasonodonnell deleted the backport-pr-20144-1.11.x branch April 17, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants