VAULT-15538: racy LDAP test #20168
Closed
VAULT-15538: racy LDAP test #20168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpalmi
reviewed
Apr 14, 2023
|
Unfortunately it is blocking CI on the release/1.12 branch. |
mpalmi
approved these changes
Apr 14, 2023
|
Is there a jira for this to make sure it is being tracked? |
https://hashicorp.atlassian.net/browse/VAULT-15538 for the racy tests, and https://hashicorp.atlassian.net/browse/VAULT-15540 (assigned to ecosystem) for the longer term fix. |
|
The issue has been fixed (#20200) so no need for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is described here: https://github.com/hashicorp/vault/pull/20144/files/0e405c39fb4ad650203c0c7b3b91cf01982b8cd4#diff-cac2ee35ce174c975632d9079d0171a80b3eb76a8d60de091a54094a7195c3dc
This is just a bandaid, any tests that we add that run in parallel and mount LDAP will also trigger the race detector.