Backport of Add fix for Go x/crypto/ocsp failure case into release/1.13.x #20199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #20181 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
When calling
ocsp.ParseRequest(req, issue)
with a non-nilissuer
on a ocsp request which unknowingly contains an entry in theBasicOCSPResponse
'scerts
field, Go incorrectly assumes that the issuer is a direct parent of the first certificate in thecerts
field, discarding the rest.As documented in the Go issue, this is not a valid assumption and thus causes OCSP verification to fail in Vault with an error like:
which ultimately leads to a cert auth login error of:
We address this by using the unsafe
issuer=nil
argument, taking on the task of validating the OCSP response's signature as best we can in the absence of full chain information on either side (both the trusted certificate whose OCSP response we're verifying and the lack of any additional certs the OCSP responder may have sent).See also: golang/go#59641
Overview of commits