Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Minor follow-ups to #16865 into release/1.13.x #20222

Merged

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #20220 to be assessed for backporting due to the inclusion of the label backport/1.13.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Fix PKI issuer upgrade logic when upgrading to 1.12 or later, to
actually turn off the issuer crl-signing usage when it intended to.

Fix minor typo in docs.

Closes #20189


Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/fix20189/internally-better-quail branch 2 times, most recently from de27943 to d8cf0fe Compare April 18, 2023 12:52
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 18, 2023

CLA assistant check
All committers have signed the CLA.

* Minor follow-ups to #16865

Fix PKI issuer upgrade logic when upgrading to 1.12 or later, to
actually turn off the issuer crl-signing usage when it intended to.

Fix minor typo in docs.

* changelog
@stevendpclark stevendpclark force-pushed the backport/fix20189/internally-better-quail branch from ffcad7b to 66fe767 Compare April 18, 2023 12:58
@stevendpclark stevendpclark marked this pull request as ready for review April 18, 2023 12:59
@stevendpclark stevendpclark requested a review from a team April 18, 2023 12:59
@stevendpclark stevendpclark self-assigned this Apr 18, 2023
@stevendpclark stevendpclark enabled auto-merge (squash) April 18, 2023 13:04
@stevendpclark stevendpclark added this to the 1.13.2 milestone Apr 18, 2023
@stevendpclark stevendpclark merged commit 73f8213 into release/1.13.x Apr 18, 2023
@stevendpclark stevendpclark deleted the backport/fix20189/internally-better-quail branch April 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants