Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Remove usage of htmlSafe #20235

Merged
merged 10 commits into from
Apr 19, 2023
Merged

UI: Remove usage of htmlSafe #20235

merged 10 commits into from
Apr 19, 2023

Conversation

hashishaw
Copy link
Contributor

This PR removes ad-hoc usages of htmlSafe and replaces it with a custom helper which sanitizes the HTML string before passing it to htmlSafe

@hashishaw hashishaw added this to the 1.14 milestone Apr 18, 2023
zofskeez
zofskeez approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! Good idea to implement this as a helper 👏. I left a couple of non blocking comments.

ui/lib/core/addon/helpers/sanitized-html.js Outdated Show resolved Hide resolved
ui/package.json Show resolved Hide resolved
ui/tests/integration/helpers/sanitized-html-test.js Outdated Show resolved Hide resolved
@hashishaw hashishaw enabled auto-merge (squash) April 19, 2023 14:48
@hashishaw hashishaw disabled auto-merge April 19, 2023 15:06
@hashishaw hashishaw enabled auto-merge (squash) April 19, 2023 15:10
@hashishaw hashishaw merged commit fae1bff into main Apr 19, 2023
This was referenced Apr 19, 2023
Closed
Closed
Merged
hashishaw added a commit that referenced this pull request Apr 19, 2023
@hashishaw
Backport PR #20235
4aa010c
@hashishaw hashishaw mentioned this pull request Apr 19, 2023
Merged
hashishaw added a commit that referenced this pull request Apr 19, 2023
@hashishaw
UI: Remove usage of htmlSafe (#20235)
054f275
@hashishaw hashishaw mentioned this pull request Apr 19, 2023
Merged
hashishaw added a commit that referenced this pull request Apr 21, 2023
@hashishaw
Backport PR #20235 - UI remove htmlSafe (#20259)
e4f78df 
* Backport PR #20235

* Fix test helper import
hashishaw added a commit that referenced this pull request Apr 21, 2023
@hashishaw
Backport UI: Remove usage of htmlSafe (#20235) (#20262)
2e27394 
* UI: Remove usage of htmlSafe (#20235)

* Fix test helper import
@hashishaw hashishaw deleted the ui/VAULT-15563/remove-htmlSafe branch May 6, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zofskeez zofskeez zofskeez approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
2 participants
@hashishaw @zofskeez